netudima commented on code in PR #4226:
URL: https://github.com/apache/cassandra/pull/4226#discussion_r2237901380
##########
bin/nodetool:
##########
@@ -43,13 +43,14 @@ if [ -z "$CASSANDRA_CONF" -o -z "$CLASSPATH" ]; then
exit 1
fi
-# Run cassandra-env.sh to pick up JMX_PORT
+JMX_PORT=""
+
+# Try to parse port from configure_jmx method call, when not commented out
if [ -f "$CASSANDRA_CONF/cassandra-env.sh" ]; then
- JVM_OPTS_SAVE=$JVM_OPTS
- MAX_HEAP_SIZE_SAVE=$MAX_HEAP_SIZE
- . "$CASSANDRA_CONF/cassandra-env.sh"
- MAX_HEAP_SIZE=$MAX_HEAP_SIZE_SAVE
- JVM_OPTS="$JVM_OPTS_SAVE"
+ jmx_method_call=$(grep "^configure_jmx \+[0-9]\+$"
$CASSANDRA_CONF/cassandra-env.sh)
Review Comment:
do we need to support cases with spaces in CASSANDRA_CONF path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
