smiklosovic commented on code in PR #4226:
URL: https://github.com/apache/cassandra/pull/4226#discussion_r2237178821


##########
tools/bin/jmxtool:
##########
@@ -37,17 +37,6 @@ if [ -z "$CASSANDRA_CONF" -o -z "$CLASSPATH" ]; then
     exit 1
 fi
 
-# Run cassandra-env.sh to pick up JMX_PORT

Review Comment:
   We can entertain this feature but it was never objective of this ticket 
anyway.  I also feel like when there is one way to set it, via `--url`, where 
port is set as part of it, then introducing JMX_PORT is just not necessary and 
does not bring anything substantial. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to