smiklosovic commented on code in PR #4340:
URL: https://github.com/apache/cassandra/pull/4340#discussion_r2301179641
##########
src/java/org/apache/cassandra/db/virtual/SettingsTable.java:
##########
@@ -89,13 +90,34 @@ public DataSet data()
@VisibleForTesting
String getValue(Property prop)
{
+ Credential maybeCredential = prop.getAnnotation(Credential.class);
+ if (maybeCredential != null)
+ return maybeCredential.redactedValue();
+
Object value = prop.get(config);
if (value == null)
return null;
if (value.getClass().isArray())
return Arrays.asList((Object[]) value).toString();
+ if (value instanceof Map)
Review Comment:
If we have a map with properties, e.g. for `ParameterizedClass`, we can not
annotate individual entries (we do not even know how much of them there will
be) so we just cover this manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
