frankgh commented on code in PR #4340: URL: https://github.com/apache/cassandra/pull/4340#discussion_r2304808571
########## src/java/org/apache/cassandra/db/virtual/SettingsTable.java: ########## @@ -89,13 +90,34 @@ public DataSet data() @VisibleForTesting String getValue(Property prop) { + Credential maybeCredential = prop.getAnnotation(Credential.class); Review Comment: yeah, I saw the comment in JIRA after I added the comment. I think it's a good point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org