smiklosovic commented on code in PR #4340:
URL: https://github.com/apache/cassandra/pull/4340#discussion_r2303211402
##########
src/java/org/apache/cassandra/db/virtual/SettingsTable.java:
##########
@@ -89,13 +90,34 @@ public DataSet data()
@VisibleForTesting
String getValue(Property prop)
{
+ Credential maybeCredential = prop.getAnnotation(Credential.class);
Review Comment:
No, I do not think so. See (1). Nobody should be able to see passwords to
anything, really.
https://issues.apache.org/jira/browse/CASSANDRA-20856?focusedCommentId=18016336&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-18016336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
