smiklosovic commented on code in PR #4379:
URL: https://github.com/apache/cassandra/pull/4379#discussion_r2353257759
##########
conf/cassandra.yaml:
##########
@@ -2502,20 +2502,41 @@ drop_compact_storage_enabled: false
# This would also apply to system keyspaces.
# maximum_replication_factor_warn_threshold: -1
# maximum_replication_factor_fail_threshold: -1
-#
+
+#role_name_policy:
+# # Implementation class of a validator. When not in form of FQCN, the
+# # package name org.apache.cassandra.db.guardrails is prepended.
+# # By default, there is no validator.
+# #validator_class_name: YourValidatorOfRoleNames
+# # Implementation class of related generator which generates values which
are valid when
+# # tested against this validator. When not in form of FQCN, the
+# # package name org.apache.cassandra.db.guardrails is prepended.
+# # By default, there is no generator.
+# # There is currently only one generator possible to configure -
UUIDRoleNameGenerator
+# generator_class_name: UUIDRoleNameGenerator
+# # Minimum generated size of a name when name_size option is specified in
CQL.
+# # This can not be less than 10 and more than 32.
+# #min_generated_name_size: 10
+
+# If this is set to false, then it is not possible to call reconfiguration
+# method in GuardrailsMBean. It will effectively forbid the reconfiguration of
role_name_policy in runtime.
+# You would need to stop the node, change the configuration in cassandra.yaml
and start the node again.
+# Defaults to true, which means that reconfiguration of role_name_policy via
JMX is possible.
+#rolename_validator_reconfiguration_enabled: true
+
# Guardrail to warn or fail when setting / altering a password.
# Supported character sets are (both upper and lower-case): English, Cyrillic
and modern Cyrillic, Czech, German, Polish.
# Password is invalid if all characters are from non-supported character set.
If a password is otherwise valid,
# but it contains characters from unsupported language, these characters
contribute only to password length rule.
# All digits and all following special characters are supported too:
!"#$%&()*+,-./:;<=>?@[\]^_`{|}~
-#password_validator:
+#password_policy:
Review Comment:
it is better if we rename this now as this has not appeared in any release
yet and it would be just too late for that otherwise. I think this better
reflects what this does as it holds both generator as well as validator under
one "policy".
##########
conf/cassandra.yaml:
##########
@@ -2502,20 +2502,41 @@ drop_compact_storage_enabled: false
# This would also apply to system keyspaces.
# maximum_replication_factor_warn_threshold: -1
# maximum_replication_factor_fail_threshold: -1
-#
+
+#role_name_policy:
+# # Implementation class of a validator. When not in form of FQCN, the
+# # package name org.apache.cassandra.db.guardrails is prepended.
+# # By default, there is no validator.
+# #validator_class_name: YourValidatorOfRoleNames
+# # Implementation class of related generator which generates values which
are valid when
+# # tested against this validator. When not in form of FQCN, the
+# # package name org.apache.cassandra.db.guardrails is prepended.
+# # By default, there is no generator.
+# # There is currently only one generator possible to configure -
UUIDRoleNameGenerator
+# generator_class_name: UUIDRoleNameGenerator
+# # Minimum generated size of a name when name_size option is specified in
CQL.
+# # This can not be less than 10 and more than 32.
+# #min_generated_name_size: 10
+
+# If this is set to false, then it is not possible to call reconfiguration
+# method in GuardrailsMBean. It will effectively forbid the reconfiguration of
role_name_policy in runtime.
+# You would need to stop the node, change the configuration in cassandra.yaml
and start the node again.
+# Defaults to true, which means that reconfiguration of role_name_policy via
JMX is possible.
+#rolename_validator_reconfiguration_enabled: true
+
# Guardrail to warn or fail when setting / altering a password.
# Supported character sets are (both upper and lower-case): English, Cyrillic
and modern Cyrillic, Czech, German, Polish.
# Password is invalid if all characters are from non-supported character set.
If a password is otherwise valid,
# but it contains characters from unsupported language, these characters
contribute only to password length rule.
# All digits and all following special characters are supported too:
!"#$%&()*+,-./:;<=>?@[\]^_`{|}~
-#password_validator:
+#password_policy:
Review Comment:
it is better if we rename this now as this has not appeared in any release
yet and it would be just too late for that otherwise. I think this better
reflects what this does as it holds both generator as well as validator under
one "policy". Same case for role name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
