smiklosovic commented on code in PR #4379:
URL: https://github.com/apache/cassandra/pull/4379#discussion_r2362788820
##########
src/antlr/Parser.g:
##########
@@ -1443,9 +1443,10 @@ createUserStatement returns [CreateRoleStatement stmt]
opts.setOption(IRoleManager.Option.LOGIN, true);
boolean superuser = false;
boolean ifNotExists = false;
+ boolean isGeneratedName = false;
RoleName name = new RoleName();
}
- : K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })?
u=username { name.setName($u.text, true); }
+ : K_CREATE (K_GENERATED { isGeneratedName = true; })? K_USER (K_IF K_NOT
K_EXISTS { ifNotExists = true; })? (u=username { name.setName($u.text, true);
})?
Review Comment:
good point about USER being deprecated. I will think about the removal of
changes, but so far we have also generated case for password for user as well
so we should remove it too then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
