smiklosovic commented on code in PR #4379:
URL: https://github.com/apache/cassandra/pull/4379#discussion_r2362776724
##########
src/java/org/apache/cassandra/auth/IRoleManager.java:
##########
@@ -72,6 +73,23 @@ public enum Option
void createRole(AuthenticatedUser performer, RoleResource role,
RoleOptions options)
throws RequestValidationException, RequestExecutionException;
+ /**
+ * Called during execution of a CREATE ROLE statement.
+ * options are guaranteed to be a subset of supportedOptions().
+ *
+ * @param performer User issuing the create role statement.
+ * @param role Rolei being created
Review Comment:
I know it might not make sense to you at first sight but this patch is not
the reason this type exists. It was not introduced here. We are addressing only
what we touch. Otherwise the fixing would be endless, even if it seems trivial.
EDIT: but this is actually OK to fix because I have been touching this
method so yes. We might fix. But the above comment still holds in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
