smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2455069120
##########
src/java/org/apache/cassandra/schema/Types.java:
##########
@@ -506,6 +587,68 @@ public long serializedSize(Types t, Version version)
size += sizeof(fieldTypes.size());
for (String s : fieldTypes)
size += sizeof(s);
+ if (version.isAtLeast(Version.V8))
+ {
+ size += BOOL_SIZE;
+ if (!StringUtils.isEmpty(type.comment))
+ size += sizeof(type.comment);
+ size += BOOL_SIZE;
+ if (!StringUtils.isEmpty(type.securityLabel))
+ size += sizeof(type.securityLabel);
+
+ size += fieldMetadataSize(type, fieldNames);
+ }
+ }
+ return size;
+ }
+
+ private void serializeFieldMetadata(UserType type, List<String>
fieldNames, DataOutputPlus out) throws IOException
+ {
+ out.writeInt(fieldNames.size());
+ for (String fieldName : fieldNames)
Review Comment:
https://github.com/smiklosovic/cassandra/commit/70013acb04316c80296487b05fc07d083abd5cc3#r168651603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
