jyothsnakonisa commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2524996949
##########
src/java/org/apache/cassandra/db/marshal/UserType.java:
##########
@@ -442,14 +471,66 @@ public UserType withUpdatedUserType(UserType udt)
{
return isMultiCell == udt.isMultiCell
? udt
- : new UserType(keyspace, name, udt.fieldNames(),
udt.fieldTypes(), isMultiCell);
+ : new UserType(keyspace, name, udt.fieldNames(),
udt.fieldTypes(), isMultiCell, udt.comment, udt.securityLabel,
udt.fieldComments, udt.fieldSecurityLabels);
}
return new UserType(keyspace,
name,
fieldNames,
Lists.newArrayList(transform(fieldTypes(), t ->
t.withUpdatedUserType(udt))),
- isMultiCell());
+ isMultiCell(),
+ comment,
+ securityLabel,
+ fieldComments,
+ fieldSecurityLabels);
+ }
+
+ public UserType withComment(String comment)
+ {
+ return new UserType(keyspace, name, fieldNames, fieldTypes(),
isMultiCell(), comment, securityLabel, fieldComments, fieldSecurityLabels);
+ }
+
+ public UserType withSecurityLabel(String securityLabel)
+ {
+ return new UserType(keyspace, name, fieldNames, fieldTypes(),
isMultiCell(), comment, securityLabel, fieldComments, fieldSecurityLabels);
+ }
+
+ public UserType withFieldComment(FieldIdentifier fieldName, String
fieldComment)
+ {
+ if (fieldPosition(fieldName) == -1)
+ throw new IllegalArgumentException(String.format("Field '%s'
doesn't exist in type '%s.%s'", fieldName, keyspace, getNameAsString()));
+
+ Map<FieldIdentifier, String> newFieldComments = new
HashMap<>(fieldComments);
+ if (fieldComment == null || fieldComment.isEmpty())
Review Comment:
Added them just for safety we don't allow empty string, I have added tests
to verify that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
