jyothsnakonisa commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2456682667
##########
src/java/org/apache/cassandra/schema/Types.java:
##########
@@ -362,26 +368,66 @@ public Types build()
}
public void add(String name, List<String> fieldNames, List<String>
fieldTypes)
+ {
+ add(name, fieldNames, fieldTypes, EMPTY_COMMENT,
EMPTY_SECURITY_LABEL, Collections.emptyList(), Collections.emptyList());
+ }
+
+ public void add(String name, List<String> fieldNames, List<String>
fieldTypes, String comment, String securityLabel)
+ {
+ add(name, fieldNames, fieldTypes, comment, securityLabel,
Collections.emptyList(), Collections.emptyList());
+ }
+
+ public void add(String name,
+ List<String> fieldNames,
+ List<String> fieldTypes,
+ String comment,
+ String securityLabel,
+ List<String> fieldComments,
+ List<String> fieldSecurityLabels)
{
List<CQL3Type.Raw> rawFieldTypes =
fieldTypes.stream()
Review Comment:
I would avoid refactoring code that is not part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
