joao-r-reis commented on code in PR #1915:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1915#discussion_r2462705489
##########
session.go:
##########
@@ -199,6 +186,20 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
}
s.connCfg = connCfg
+ if cfg.PoolConfig.HostSelectionPolicy == nil {
+ cfg.PoolConfig.HostSelectionPolicy = RoundRobinHostPolicy()
+ }
+ s.pool = cfg.PoolConfig.buildPool(s)
+ s.policy = cfg.PoolConfig.HostSelectionPolicy
+
+ // set the executor here in case the policy needs to execute queries in
Init
Review Comment:
yeah honestly it doesn't make a lot of sense that we're passing the Session
in the Init method because it's not clear exactly which methods of the Session
type API can actually be used by the policy at that point. I think the best we
can do at this point is to document this in the the Init method docs because
any other way of addressing this probably requires a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
