joao-r-reis commented on code in PR #1915:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1915#discussion_r2466481459
##########
session.go:
##########
@@ -199,6 +186,20 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
}
s.connCfg = connCfg
+ if cfg.PoolConfig.HostSelectionPolicy == nil {
+ cfg.PoolConfig.HostSelectionPolicy = RoundRobinHostPolicy()
+ }
+ s.pool = cfg.PoolConfig.buildPool(s)
+ s.policy = cfg.PoolConfig.HostSelectionPolicy
+
+ // set the executor here in case the policy needs to execute queries in
Init
Review Comment:
👍 I'm actually curious to know what happens now with these changes, there is
an executor but there is no hosts or connection pools, the ideal fix would be
for the policy to get notified somehow that the session has finished
initializing. Ideally the driver would do that on its own but without this I
guess the user creating the policy has to write that code on the app side
In any case we can keep these changes sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
