joao-r-reis commented on PR #1915: URL: https://github.com/apache/cassandra-gocql-driver/pull/1915#issuecomment-3446529319
> I wasn't necessarily intending on it being realistic to fix all of the things I brought up especially the ones with workarounds. That makes sense, I'd say we rename the issue to `Add a public method to retrieve StatementMetadata` or something like that to make it more specific as to what this PR is doing but you can keep the description that talks about the usability of the policy because that's good context that we can refer to later. > Could I just make another issue for the `Context()` method on `ExecutableStatement`? Not sure if it's worth breaking the interface but it might be? We can decide separately but as-is it's not insurmountable. Yeah go for it. I'm also not sure about whether it's worth breaking the interface, I think I'd rather document how users can achieve that by type casting the object returned by `Statement()`. I added the `Statement()` method so that users could keep the functionality of type casting to `Query` or `Batch` which might be useful at times. I do think we should create JIRAs for these things that require breaking changes and tag them with an appropriate label so that we can address them when we work on a 3.0. I'd say creating one to review the HostSelectionPolicy API (especially the Init method) and one to review `ExecutableStatement`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
