blambov commented on code in PR #4402:
URL: https://github.com/apache/cassandra/pull/4402#discussion_r2486559789
##########
src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java:
##########
@@ -299,6 +320,29 @@ public MetadataCollector tokenSpaceCoverage(double
coverage)
return this;
}
+ public void updateClusteringValues(ClusteringDescriptor newClustering) {
+ if (newClustering == null ||
newClustering.clusteringKind().isBoundary())
Review Comment:
The reason for doing nothing on `isBoundary` is not obvious. This is the
comment I am referring to:
```
// In a SSTable, every opening marker will be closed, so the start
of a range tombstone marker will never be
// the maxClustering (the corresponding close might though) and
there is no point in doing the comparison
// (and vice-versa for the close). By the same reasoning, a boundary
will never be either the min or max
// clustering, and we can save on comparisons.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
