nitsanw commented on code in PR #4402:
URL: https://github.com/apache/cassandra/pull/4402#discussion_r2497955526
##########
src/java/org/apache/cassandra/db/compaction/AbstractCompactionPipeline.java:
##########
@@ -31,14 +31,12 @@
import java.util.Set;
abstract class AbstractCompactionPipeline extends CompactionInfo.Holder
implements AutoCloseable {
- static AbstractCompactionPipeline create(CompactionTask task,
OperationType type, AbstractCompactionStrategy.ScannerList scanners,
AbstractCompactionController controller, long nowInSec, TimeUUID compactionId) {
+ static AbstractCompactionPipeline create(CompactionTask task,
OperationType type, AbstractCompactionStrategy.ScannerList scanners,
AbstractCompactionController controller, long nowInSec, TimeUUID compactionId)
+ {
if (DatabaseDescriptor.enableCursorCompaction()) {
- try {
+ if (CompactionCursor.isSupported(scanners, controller))
Review Comment:
This is now debug logged in the `isSupported` method, with a reason for the
rejection. Do you think further logging is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
