blambov commented on code in PR #4402:
URL: https://github.com/apache/cassandra/pull/4402#discussion_r2486580490
##########
src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java:
##########
@@ -361,6 +405,13 @@ public Map<MetadataType, MetadataComponent>
finalizeMetadata(String partitioner,
Map<MetadataType, MetadataComponent> components = new
EnumMap<>(MetadataType.class);
components.put(MetadataType.VALIDATION, new
ValidationMetadata(partitioner, bloomFilterFPChance));
+ Slice coveredClustering;
+ if (minClusteringDescriptor.clusteringKind() !=
ClusteringPrefix.Kind.EXCL_START_BOUND) // min is end only if the descriptors
are unused
Review Comment:
`MAX_START` also has an empty values array, while this line only checks the
kind of clustering (i.e. the ` &&
minClusteringDescriptor.clusteringColumnsBound() == 0` part is missing here).
The additional check is necessary, as the code as it stands will do the wrong
thing for sstables whose lower limit is a range tombstone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
