maedhroz commented on code in PR #4428:
URL: https://github.com/apache/cassandra/pull/4428#discussion_r2529097981
##########
src/java/org/apache/cassandra/db/compaction/CompactionTask.java:
##########
@@ -397,6 +397,7 @@ public static ImmutableCoordinatorLogOffsets
getCoordinatorLogOffsets(Set<SSTabl
ImmutableCoordinatorLogOffsets.Builder builder = new
ImmutableCoordinatorLogOffsets.Builder();
for (SSTableReader sstable : sstables)
builder.addAll(sstable.getCoordinatorLogOffsets());
+ builder.purgeTransfers();
Review Comment:
So the idea here is that transfer IDs that are durably reconciled will never
trigger reconciliation anyway...so they just don't need to be in the new
post-compaction SSTables? Makes sense, although I wonder if a short comment to
that effect would be helpful...or...rename to `purgeReconciledTransfers()`...or
maybe by favorite...make `Predicate<ShortMutationId> pred` an argument for
`purgeTransfers()` and pass
`MutationTrackingService.instance::isDurablyReconciled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
