aratno commented on code in PR #4428:
URL: https://github.com/apache/cassandra/pull/4428#discussion_r2535471870
##########
src/java/org/apache/cassandra/db/lifecycle/Tracker.java:
##########
@@ -270,6 +272,20 @@ public void
updateInitialSSTableSize(Iterable<SSTableReader> sstables)
public void addSSTables(Collection<SSTableReader> sstables)
{
+
Preconditions.checkState(!cfstore.metadata().replicationType().isTracked());
+ addSSTablesInternal(sstables, false, true, true);
+ }
+
+ public void addSSTablesTracked(Collection<SSTableReader> sstables)
+ {
+
Preconditions.checkState(cfstore.metadata().replicationType().isTracked());
+ for (SSTableReader sstable : sstables)
+ {
+ ImmutableCoordinatorLogOffsets logOffsets =
sstable.getCoordinatorLogOffsets();
+ Preconditions.checkState(logOffsets.mutations().isEmpty());
+ Preconditions.checkState(!logOffsets.transfers().isEmpty());
Review Comment:
I'm not sure what isTransfer would represent, given that we'll have ICLO
containing a mix of mutations and transfers after compaction has happened. I
can make this throw a "real" exception though, with a message containing
logOffsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
