maedhroz commented on code in PR #4428:
URL: https://github.com/apache/cassandra/pull/4428#discussion_r2535484631
##########
src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java:
##########
@@ -104,7 +104,7 @@ public Predicate<SSTableReader>
getSSTablePredicateForKeyspaceRanges(ReconciledK
// if it's not repaired and there are no offsets, it was probably
written before the table was using
// mutation tracking and therefore should be considered
unreconciled
- if (sstableOffsets.isEmpty())
+ if (sstableOffsets.mutations().isEmpty() &&
sstableOffsets.transfers().isEmpty())
Review Comment:
It might be a nice to still have an overall `isEmpty()` method that covers
both and leaves this class unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
