dcapwell commented on code in PR #4509:
URL: https://github.com/apache/cassandra/pull/4509#discussion_r2590148387
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -753,11 +773,124 @@ public ReferenceExpression visit(ReferenceExpression r)
return process(Who.cas, updatedCondition, lets);
}
+ public Consumer<ThrowableAssert.ThrowingCallable> shouldReject(Txn txn)
+ {
+ if (!shouldApply(txn)) return null;
+ List<Mutation> mutations = null;
+ if (txn.ifBlock.isPresent()) mutations = txn.ifBlock.get().mutations;
+ else if (!txn.mutations.isEmpty()) mutations = txn.mutations;
+
+ if (mutations == null) return null;
Review Comment:
its not a true/false though, its "did it fail correctly" that matters.
Example is in accord, when we hit the issues that this PR updates we
actually fail incorrectly... so if we just return true/false we wouldn't detect
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
