dcapwell commented on code in PR #4509:
URL: https://github.com/apache/cassandra/pull/4509#discussion_r2590246794
##########
src/java/org/apache/cassandra/utils/caching/TinyThreadLocalPool.java:
##########
@@ -46,10 +48,23 @@ public void offer(V value)
}
private void offerSafe(V value)
{
+ if (DEBUG)
Review Comment:
if you have 3 rows in a update, we will offer the same reference 3 times!
This check now detects that and fails; but you must be in "debug mode" to hit
that... I updated `CQLTester` and jvm-dtest to be in debug mode so we should
see these cases in tests 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
