dcapwell commented on code in PR #4509:
URL: https://github.com/apache/cassandra/pull/4509#discussion_r2590906284
##########
src/java/org/apache/cassandra/cql3/UpdateParameters.java:
##########
@@ -108,20 +105,8 @@ public <V> void newRow(Clustering<V> clustering) throws
InvalidRequestException
throw new InvalidRequestException("Invalid empty or null
value for column " + metadata.clusteringColumns().get(0).name);
}
}
-
- if (clustering == Clustering.STATIC_CLUSTERING)
- {
- if (staticBuilder == null)
- staticBuilder = BTreeRow.pooledUnsortedBuilder();
- builder = staticBuilder;
- }
- else
- {
- if (regularBuilder == null)
- regularBuilder = BTreeRow.pooledUnsortedBuilder();
- builder = regularBuilder;
Review Comment:
yes, that is what caused all this logic to be changed. the AST tests were
hitting it which lead to this discovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
