bdeggleston commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2600257650
##########
src/java/org/apache/cassandra/service/consensus/migration/ConsensusMigrationMutationHelper.java:
##########
@@ -275,21 +270,27 @@ public SplitMutation(@Nullable T accordMutation,
@Nullable T untrackedMutation,
public <T extends IMutation> SplitMutation<T> splitMutation(T mutation,
ClusterMetadata cm)
{
- boolean isTracked = isTrackedMutation(mutation);
+ Token token = mutation.key().getToken();
+ Predicate<TableId> isTrackedUpdate = tableId ->
MigrationRouter.shouldUseTrackedForWrites(cm, mutation.getKeyspaceName(),
tableId, token);
+ Predicate<TableId> isUntrackedUpdate = not(isTrackedUpdate);
if (mutation.potentialTxnConflicts().allowed)
- return new SplitMutation<>(null, isTracked ? null : mutation,
isTracked ? mutation : null);
+ {
Review Comment:
This sounds like something that would be better looked into and addressed
separately. I'm not 100% sure we're not going to break some obscure accord edge
case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
