bdeggleston commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2600549969
##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -403,7 +404,7 @@ public void initCf(TableMetadata metadata, boolean
loadSSTables)
public Future<?> applyFuture(Mutation mutation, boolean writeCommitLog,
boolean updateIndexes)
{
- return getMetadata().useMutationTracking()
+ return MigrationRouter.isFullyTracked(mutation)
Review Comment:
We don't bypass mutation tracking plumbing during migration. The use of
`MigrationRouter.isFullyTracked(mutation)` here is making the assumption that
the mutation routing logic did it's job properly higher up the stack and has
already produced mutations that are either fully tracked or fully untracked.
Probably the right thing to do here is confirm that the mutation is fully one
or the other and select the correct path accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
