aweisberg commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2611365197
##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -404,9 +404,17 @@ public void initCf(TableMetadata metadata, boolean
loadSSTables)
public Future<?> applyFuture(Mutation mutation, boolean writeCommitLog,
boolean updateIndexes)
{
- return MigrationRouter.isFullyTracked(mutation)
- ? applyInternalTracked(mutation, new AsyncPromise<>())
- : applyInternal(mutation, writeCommitLog, updateIndexes, true,
true, new AsyncPromise<>());
+ MigrationRouter.MutationRouting routing =
MigrationRouter.getMutationRouting(mutation);
+ switch (routing)
+ {
+ case UNTRACKED:
+ return applyInternal(mutation, writeCommitLog, updateIndexes,
true, true, new AsyncPromise<>());
+ case TRACKED:
+ return applyInternalTracked(mutation, new AsyncPromise<>());
+ case MIXED:
Review Comment:
This looks quite problematic because it's going to happen when migrating
away from mutation tracking and then your unlogged batches stop working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
