jberragan commented on code in PR #294:
URL: https://github.com/apache/cassandra-sidecar/pull/294#discussion_r2637021902
##########
server/src/main/java/org/apache/cassandra/sidecar/cdc/CdcConfigImpl.java:
##########
@@ -17,78 +17,64 @@
*/
package org.apache.cassandra.sidecar.cdc;
-import java.util.ArrayList;
-import java.util.Collections;
import java.util.HashMap;
-import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
-import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableMap;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import com.google.inject.Inject;
import com.google.inject.Singleton;
-import io.vertx.core.Promise;
+import io.vertx.core.Handler;
-import org.apache.cassandra.sidecar.common.server.ThrowingRunnable;
-import org.apache.cassandra.sidecar.common.server.utils.DurationSpec;
+import io.vertx.core.Vertx;
+import io.vertx.core.eventbus.Message;
import
org.apache.cassandra.sidecar.common.server.utils.MillisecondBoundConfiguration;
import
org.apache.cassandra.sidecar.common.server.utils.SecondBoundConfiguration;
-import org.apache.cassandra.sidecar.config.CdcConfiguration;
-import org.apache.cassandra.sidecar.config.SchemaKeyspaceConfiguration;
-import org.apache.cassandra.sidecar.config.SidecarConfiguration;
import org.apache.cassandra.sidecar.db.CdcConfigAccessor;
-import org.apache.cassandra.sidecar.db.KafkaConfigAccessor;
-import org.apache.cassandra.sidecar.tasks.PeriodicTask;
-import org.apache.cassandra.sidecar.tasks.PeriodicTaskExecutor;
-import org.apache.cassandra.sidecar.tasks.ScheduleDecision;
+import org.apache.cassandra.sidecar.tasks.CdcConfigRefresherNotifierTask;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
+import static
org.apache.cassandra.sidecar.server.SidecarServerEvents.ON_CDC_CONFIGURATION_CHANGED;
+import static
org.apache.cassandra.sidecar.server.SidecarServerEvents.ON_CDC_CONFIG_MAPPINGS_CHANGED;
+
/**
* Implementation of the interface {@link CdcConfig}, an in-memory
representation holding
* CDC and Kafka configurations from "configs" table inside sidecar internal
keyspace.
*/
@Singleton
public class CdcConfigImpl implements CdcConfig
{
- private static final Logger LOGGER =
LoggerFactory.getLogger(CdcConfigImpl.class);
private static final int DEFAULT_MAX_WATERMARKER_SIZE = 400000;
private static final String DEFAULT_JOB_ID = "test-job-id";
private static final int DEFAULT_MAX_COMMITLOGS_PER_INSTANCE = 4;
private static final int DEFAULT_MAX_RECORD_BYTE_SIZE = -1;
public static final int DEFAULT_WATERMARK_WINDOW = 259200;
- private final SchemaKeyspaceConfiguration schemaKeyspaceConfiguration;
- private final CdcConfiguration cdcConfiguration;
+ private final Vertx vertx;
private final CdcConfigAccessor cdcConfigAccessor;
- private final KafkaConfigAccessor kafkaConfigAccessor;
- private final List<ThrowingRunnable> configChangeListeners =
Collections.synchronizedList(new ArrayList<>());
- private final ConfigRefreshNotifier configRefreshNotifier;
- private volatile Map<String, String> kafkaConfigMappings = Map.of();
- private volatile Map<String, String> cdcConfigMappings = Map.of();
+
+ private Map<String, String> kafkaConfigMappings = Map.of();
Review Comment:
There not accessed with `synchronized` so better to make them `volatile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
