michaelsembwever commented on code in PR #4506:
URL: https://github.com/apache/cassandra/pull/4506#discussion_r2616381319
##########
src/java/org/apache/cassandra/cql3/QueryOptions.java:
##########
@@ -127,6 +132,30 @@ public static QueryOptions withPageSize(QueryOptions
options, int pageSize)
public abstract ConsistencyLevel getConsistency();
public abstract List<ByteBuffer> getValues();
+
+ public abstract int getValuesSize();
+
+ public ByteBuffer getValue(int index)
+ {
+ return getValues().get(index);
+ }
+
+ /**
+ * to check if it is possible to get values as byte[] instead of ByteBuffer
+ * the logic is added as a memory allocation optimization
+ * to avoid creating of HeapByteBuffer wrappers for some typical requests
+ * getValues method is still in use and must be supported even if true is
returned
+ */
+ public boolean isByteArrayValuesGetSupported()
+ {
+ return false;
+ }
+
+ public byte[][] getByteArrayValues()
+ {
+ throw new UnsupportedOperationException();
Review Comment:
msg ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]