michaelsembwever commented on code in PR #4506:
URL: https://github.com/apache/cassandra/pull/4506#discussion_r2616540701
##########
src/java/org/apache/cassandra/audit/AuditLogManager.java:
##########
@@ -358,7 +357,7 @@ public void batchSuccess(BatchStatement.Type batchType,
}
}
- public void batchFailure(BatchStatement.Type batchType, List<? extends
CQLStatement> statements, List<String> queries, List<List<ByteBuffer>> values,
QueryOptions options, QueryState state, Exception cause)
+ public void batchFailure(BatchStatement.Type batchType, List<? extends
CQLStatement> statements, List<String> queries, List<byte[][]> values,
QueryOptions options, QueryState state, Exception cause)
Review Comment:
in many signatures we're changing ByteBuffer to byte[] for reasons obvious
in the context of this ticket– the caller is always expected to have the whole
array
but i'm curious how newcomers to the codebase discern when they are supposed
to be using byte[] vs ByteBuffer… as they need to know why, as well as have a
pretty good idea about the codebase to know where the why applies… (and this
goes into the megamorphic too…)
this is an open question, and maybe it is implied and obvious enough… 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
