netudima commented on code in PR #4506:
URL: https://github.com/apache/cassandra/pull/4506#discussion_r2617335625
##########
src/java/org/apache/cassandra/audit/AuditLogManager.java:
##########
@@ -358,7 +357,7 @@ public void batchSuccess(BatchStatement.Type batchType,
}
}
- public void batchFailure(BatchStatement.Type batchType, List<? extends
CQLStatement> statements, List<String> queries, List<List<ByteBuffer>> values,
QueryOptions options, QueryState state, Exception cause)
+ public void batchFailure(BatchStatement.Type batchType, List<? extends
CQLStatement> statements, List<String> queries, List<byte[][]> values,
QueryOptions options, QueryState state, Exception cause)
Review Comment:
I afraid I do not have a good general answer.., it is very
context-dependent. Like, we already have ByteBuffer vs ByteBuf or List vs
google ImmutableList, etc in our codebase, usually it is just following of the
types you've got as inputs for you logic and so on, but at some points for perf
or decoupling reasons you have to switch/convert/clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
