smiklosovic commented on code in PR #4487:
URL: https://github.com/apache/cassandra/pull/4487#discussion_r2622926590
##########
src/java/org/apache/cassandra/service/AsyncProfilerService.java:
##########
@@ -223,12 +239,23 @@ public Object apply(AsyncProfiler profiler) throws
Throwable
}
}
+ private void validateStartParameters(Map<String, String> parameters)
Review Comment:
can you please move this method down, before `validateStopParameters`? I do
not like that we mix public method with private, just move private down so it
is not distracting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
