smiklosovic commented on code in PR #4487:
URL: https://github.com/apache/cassandra/pull/4487#discussion_r2623117322
##########
src/java/org/apache/cassandra/tools/nodetool/AsyncProfileCommandGroup.java:
##########
@@ -150,7 +157,8 @@ public void execute(NodeProbe probe)
{
doWithProfiler(probe, profiler -> {
String file = filename != null ?
validateOutputFileName(filename) : null;
- if (!profiler.stop(file))
+ Map<String, String> stopParameters =
Map.of(ASYNC_PROFILER_STOP_OUTPUT_FILE_NAME_PARAM, file);
Review Comment:
this fails when file is not specified on command line, it fails to create a
map where value of that entry is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
