maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2670431504
##########
src/java/org/apache/cassandra/index/sai/plan/QueryController.java:
##########
@@ -171,6 +175,39 @@ public UnfilteredRowIterator queryStorage(List<PrimaryKey>
keys, ReadExecutionCo
return partition.queryMemtableAndDisk(cfs, executionController);
}
+ /**
+ * Get an iterator over the rows for this partition key. Restrict the
search to the specified view.
+ * @param key
+ * @param executionController
+ * @return
+ */
+ public UnfilteredRowIterator queryStorage(PrimaryKey key,
ColumnFamilyStore.ViewFragment view, ReadExecutionController
executionController)
+ {
+ if (key == null)
+ throw new IllegalArgumentException("non-null key required");
+
+ // TODO how do we want to handle static rows?
Review Comment:
Looking at `readAndValidatePartition()`, the caller, are you worried about
static rows not being wrapped with a `RowWithSourceTable` and breaking
`isIndexDataValid()`? How would we test that...a query that only reads and
filters static columns? ANN query against a single static column that forces us
to check the validity of the static row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
