maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2673866562
##########
src/java/org/apache/cassandra/index/sai/memory/VectorMemoryIndex.java:
##########
@@ -241,6 +253,30 @@ private int maxBruteForceRows(int limit, int
nPermittedOrdinals, int graphSize)
return (int) max(limit, memoryToDiskFactor * expectedComparisons);
Review Comment:
Does `VectorMemoryIndex` ever actually hit disk? It seems like the only time
it touches disk is on Memtable flush. So if the non-brute force case isn't
hitting disk, what is it doing? It seems like it's searching the in-memory
graph index and doing a bunch of node/ordinal -> primary key conversions.
(`orderBy()` and `orderResultsBy()` both seem to return score sorted keys
now, so it doesn't seem like our choice of brute force vs. non-brute force has
an impact on the amount of row materialization we do downstream...or am I
reading that wrong?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
