michaeljmarshall commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2673984794
##########
src/java/org/apache/cassandra/index/sai/memory/VectorMemoryIndex.java:
##########
@@ -241,6 +253,30 @@ private int maxBruteForceRows(int limit, int
nPermittedOrdinals, int graphSize)
return (int) max(limit, memoryToDiskFactor * expectedComparisons);
Review Comment:
The in memory vector index itself will not hit disk. Row materialization
might, but this comment seems incorrect.
The decision point here is about the number of comparisons expected in graph
traversal versus in brute force.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
