smiklosovic commented on code in PR #4547: URL: https://github.com/apache/cassandra/pull/4547#discussion_r2682426503
########## conf/cassandra.yaml: ########## @@ -2517,6 +2517,10 @@ drop_compact_storage_enabled: false # Min unit: B # data_disk_usage_max_disk_size: # +# Configures the disk usage guardrails to block all writes to a keyspace if any node which replicates that keyspace +# is full. By default, this is disabled. +# data_disk_usage_stop_writes_for_keyspace_on_fail: false Review Comment: I do not think this is a good naming convention. We have _flags_ (ending on "enabled"), _thresholds, ending on _threshold_, and values, ending on "_ignored, _disallowed, _warned". Your implementation does not adhere to anything like that. If you do not want to have two levels - _warn and _fail and you want to have just "fail" one, then `data_disk_usage_stop_writes_on_any_full_node_enabled: false` seems to be better. I do not `...for_keyspace_on_fail` - that is - there is no _keyspace_ we would set, right? Your guardrail is "keyspace agnostic", any keyspace would fill the node, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
