isaacreath commented on code in PR #4547: URL: https://github.com/apache/cassandra/pull/4547#discussion_r2682465387
########## conf/cassandra.yaml: ########## @@ -2517,6 +2517,10 @@ drop_compact_storage_enabled: false # Min unit: B # data_disk_usage_max_disk_size: # +# Configures the disk usage guardrails to block all writes to a keyspace if any node which replicates that keyspace +# is full. By default, this is disabled. +# data_disk_usage_stop_writes_for_keyspace_on_fail: false Review Comment: I agree, I do not love the name I chose either. I struggle to find the right way to express the concept. I like `data_disk_usage_stop_writes_on_any_full_node_enabled`, but with the caveat that this doesn't block writes to the whole cluster, just to any node in any data center which overlaps with the the full node. For example, if we have a cluster with 3 DCs, `DC1`, `DC2`, and `DC3` and two keyspaces: `keyspace_1` and `keyspace_2`. `keyspace_1` has replication in `DC1` and `DC2` and `keyspace_2` has replication `DC2` and `DC3`. If there is a full node in `DC1`, writes to `keyspace_1` will fail, but `keyspace_2` will succeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
