smiklosovic commented on code in PR #4547: URL: https://github.com/apache/cassandra/pull/4547#discussion_r2683847940
########## conf/cassandra.yaml: ########## @@ -2517,6 +2517,10 @@ drop_compact_storage_enabled: false # Min unit: B # data_disk_usage_max_disk_size: # +# Configures the disk usage guardrails to block all writes to a keyspace if any node which replicates that keyspace +# is full. By default, this is disabled. +# data_disk_usage_stop_writes_for_keyspace_on_fail: false Review Comment: Not sure about the semantics here just saying that if you do it like that then it will not be "flag" anymore (in guardrails context). Actually, I do not see the actual implementation of that guardrail in `Guardrails` class. Roughly first half of that class is about guardrails declarations, you just put the setter and getter there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
