dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2683914797
##########
src/java/org/apache/cassandra/service/paxos/PaxosCommit.java:
##########
@@ -312,14 +314,19 @@ public void doVerb(Message<Agreed> message)
if (response == null)
MessagingService.instance().respondWithFailure(UNKNOWN,
message);
else
- MessagingService.instance().respond(response, message);
+ {
+ Message<NoPayload> reply = message.responseWith(response);
+ reply = MessageParams.addToMessage(reply);
+ MessagingService.instance().respond(reply, message);
+ }
}
private static NoPayload execute(Agreed agreed, InetAddressAndPort
from)
{
if (!Paxos.isInRangeAndShouldProcess(from,
agreed.update.partitionKey(), agreed.update.metadata(), false))
return null;
+ WriteThresholds.checkWriteThresholds(agreed.update,
agreed.update.partitionKey());
Review Comment:
im not sure if this would actually work in practice
```
if (executeOnSelf)
{
ExecutorPlus executor = PAXOS_COMMIT_REQ.stage.executor();
if (async) executor.execute(this::executeOnSelf);
else executor.maybeExecuteImmediately(this::executeOnSelf);
}
```
in some code paths we do a blocking execute, in others we do it async and
ignore when it completes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
