dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2688280668
##########
src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java:
##########
@@ -656,6 +657,10 @@ private ResultMessage executeWithoutCondition(QueryState
queryState, QueryOption
);
if (!mutations.isEmpty())
{
+ // Check write thresholds at coordinator level - similar to read
threshold checking
+ maybeWarnWriteSize(mutations, options);
+ maybeWarnWriteTombstones(mutations, options);
Review Comment:
> we do have a pre-check on large read operations
are those not different checks? There is `read_size` which is replica, and
`coordinator_read_size` which is how much the coordinator used; this check has
2 very different definitions and won't be clear from client point of view what
happens if these checks actually return a warn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
