minal-kyada commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2685046049
##########
src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java:
##########
@@ -656,6 +657,10 @@ private ResultMessage executeWithoutCondition(QueryState
queryState, QueryOption
);
if (!mutations.isEmpty())
{
+ // Check write thresholds at coordinator level - similar to read
threshold checking
+ maybeWarnWriteSize(mutations, options);
+ maybeWarnWriteTombstones(mutations, options);
Review Comment:
This is a pre-flight check at the co-ordinator side, it's tracking large
write operations, I added this because today we do have a pre-check on large
read operations, and we take actions against those calls, should we have a
similar implementation for write too?
Additionally, I have implemented replica side write threshold check too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
