aweisberg commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2710051799
##########
src/java/org/apache/cassandra/replication/MutationTrackingService.java:
##########
@@ -305,6 +307,19 @@ public void updateReplicatedOffsets(String keyspace,
Range<Token> range, List<?
try
{
getOrCreateShards(keyspace).updateReplicatedOffsets(range,
offsets, durable, onHost);
+
+ // Notify any registered sync coordinators about the offset update
+ Set<MutationTrackingSyncCoordinator> coordinators =
syncCoordinatorsByKeyspace.get(keyspace);
Review Comment:
How many shards are there generally going to be? Does this need to be done
under this lock?
I am wondering if validating the impact of these offsets being updated can
be done outside the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
