bdeggleston commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2718011459
##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -283,6 +283,24 @@ Offsets.Immutable collectReconciledOffsets()
}
}
+ /**
+ * Returns the UNION of all witnessed offsets from all participants.
+ * This represents all offsets that ANY replica has witnessed.
+ */
+ Offsets.Immutable collectUnionOfWitnessedOffsets()
Review Comment:
yes that's right. We'd need to either proactively contact each replica, or
just listen to what offsets the other nodes are broadcasting starting _after_
the IR starts.
You'd need to timeout if you don't get offsets from a participant after some
amount of time too. I think this might be a bit easier by listening to incoming
offsets and waiting on a future that times out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
