aweisberg commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2717932020
##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -283,6 +283,24 @@ Offsets.Immutable collectReconciledOffsets()
}
}
+ /**
+ * Returns the UNION of all witnessed offsets from all participants.
+ * This represents all offsets that ANY replica has witnessed.
+ */
+ Offsets.Immutable collectUnionOfWitnessedOffsets()
Review Comment:
This is operating at the MutationTrackingSyncCoordinator which is just one
node's view of the offsets from the coordinators that can be arbitrarily behind
or incomplete.
To collect the offsets I think the best thing to do is contact every replica
of the shard and ask them for all the coordinators they know about and what the
maximum offset seen was and union the result of that.
@bdeggleston do I have this right? I don't think the repair will have
happens before relationship for acknowledged writes without it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
