smiklosovic commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2752171123
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -5483,6 +5483,19 @@ public static void setUseStatementsEnabled(boolean
enabled)
}
}
+ public static boolean getMispreparedStatementsEnabled()
+ {
+ return conf.misprepared_statements_enabled;
+ }
+
+ public static void setMispreparedStatementsEnabled(boolean enabled)
Review Comment:
why is it important for you to wrap this in "if"? Why do you want to log?
All other setters are pretty simple, just assign a value to that. Do not log
nor do ifs. I understand that you probably wanted to copy how it was done in
case of setUseStatementsEnabled but that was probably done as an exception, not
something to be followed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
