aweisberg commented on code in PR #4569:
URL: https://github.com/apache/cassandra/pull/4569#discussion_r2756012252
##########
src/java/org/apache/cassandra/repair/MutationTrackingIncrementalRepairTask.java:
##########
@@ -140,7 +141,13 @@ private void
waitForSyncCompletion(List<MutationTrackingSyncCoordinator> syncCoo
else
{
// Pure mutation tracking - create successful result
-
resultPromise.trySuccess(CoordinatedRepairResult.create(rangeCollections,
List.of()));
+ List<RepairSessionResult> results = new ArrayList<>();
+ for (int i = 0; i < rangeCollections.size(); i++)
+ {
+ Collection<Range<Token>> ranges = rangeCollections.get(i);
+ results.add(new RepairSessionResult(parentSession, keyspace,
ranges, List.of(), false));
Review Comment:
Force needs to work that means the false can't be hardcoded and that if
there are down nodes repair needs to work and also specific hosts needs to be
supported. These are required for repair before replace.
##########
src/java/org/apache/cassandra/repair/MutationTrackingIncrementalRepairTask.java:
##########
@@ -140,7 +141,13 @@ private void
waitForSyncCompletion(List<MutationTrackingSyncCoordinator> syncCoo
else
{
// Pure mutation tracking - create successful result
-
resultPromise.trySuccess(CoordinatedRepairResult.create(rangeCollections,
List.of()));
+ List<RepairSessionResult> results = new ArrayList<>();
+ for (int i = 0; i < rangeCollections.size(); i++)
+ {
+ Collection<Range<Token>> ranges = rangeCollections.get(i);
+ results.add(new RepairSessionResult(parentSession, keyspace,
ranges, List.of(), false));
Review Comment:
The listener also needs RepairResult instances instead of Lists.of() for
migration to work since that is what it listens for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
