absurdfarce commented on code in PR #2063: URL: https://github.com/apache/cassandra-java-driver/pull/2063#discussion_r3049498962
########## manual/core/non_blocking/README.md: ########## @@ -155,10 +155,17 @@ should not be used if strict lock-freedom is enforced. The `RateLimitingRequestThrottler` is currently blocking. The `ConcurrencyLimitingRequestThrottler` is lock-free. -See the section about [throttling](../throttling) for details about these components. Depending on +See the section about [throttling](../throttling/README.md) for details about these components. Depending on how many requests are being executed in parallel, the thread contention on these locks can be high: in short, if your application enforces strict lock-freedom, then you should not use the `RateLimitingRequestThrottler`. +* `ConcurrencyLimitingRequestThrottler` +* `RateLimitingRequestThrottler` + +See the section about [throttling](../throttling/README.md) for details about these components. Again, they +use locks internally, and depending on how many requests are being executed in parallel, the thread +contention on these locks can be high: in short, if your application enforces strict lock-freedom, +then these components should not be used. Review Comment: Nice! After cleanup this looks exactly like what I'd expect. Looks much better in Github's rendering as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
