absurdfarce commented on code in PR #2063:
URL:
https://github.com/apache/cassandra-java-driver/pull/2063#discussion_r3049506340
##########
core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java:
##########
@@ -1022,8 +1022,8 @@ public enum DefaultDriverOption implements DriverOption {
* }
* </pre>
*
- * Note: subnets must be represented as prefix blocks, see {@link
- * inet.ipaddr.Address#isPrefixBlock()}.
+ * Note: subnets must be represented as prefix blocks, see <a
+ *
href="https://javadoc.io/doc/com.github.seancfoley/ipaddress/latest/inet/ipaddr/Address.html#isPrefixBlock--";>inet.ipaddr.Address.isPrefixBlock()</a>
Review Comment:
Sweet, I think this will offer better guidance to users. I'll admit that
there is part of me which is tempted to inline the definition of prefix block
into this comment... but we don't have to take that step now. I'm happy with
the way it stands now; it's a definite improvement over what was there
originally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
