frankgh commented on code in PR #4892:
URL: https://github.com/apache/cassandra/pull/4892#discussion_r3446473467
##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -628,11 +628,11 @@ private Future<?> applyInternalTracked(Mutation mutation,
Promise<?> future)
throw new RuntimeException("Testing write failures");
boolean started;
- try (WriteContext ctx = trackedWriteHandler.beginWrite(mutation, true))
+ try (WriteContext ctx = trackedWriteHandler.beginWrite(mutation,
makeDurable))
{
started =
MutationTrackingService.instance().startWriting(mutation);
- if (started)
+ if (started || !makeDurable)
Review Comment:
so basically, the question is whether on line 633 do we need to write the
journal when we don't need durable writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
