frankgh commented on code in PR #4892:
URL: https://github.com/apache/cassandra/pull/4892#discussion_r3447786548
##########
test/unit/org/apache/cassandra/tcm/transformations/AlterSchemaMutationTrackingTest.java:
##########
@@ -372,4 +374,68 @@ private void
assertStatesEqual(MutationTrackingMigrationState expected, Mutation
assertEquals(expectedInfo, actualInfo);
}
}
+
+ /**
+ * The mutation journal can't be disabled for tracked replication, so
attempting to set durable_writes=false
+ * on tracked keyspaces needs to fail validation
+ */
+ @Test
+ public void testRejectDurableWritesFalseOnTrackedKeyspace()
+ {
+ // CREATE: tracked + durable_writes=false should be rejected
+ String createKs = nextKsName();
+ Throwable createFailure = expectFailure(() ->
+ schemaChange("CREATE KEYSPACE " + createKs +
Review Comment:
👍 yeah, this makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
